Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build break caused by exported deprecated functions #17719

Merged
merged 1 commit into from
Nov 25, 2021

Commits on Nov 25, 2021

  1. chore: fix build break caused by exported deprecated functions

    Functions (not member methods) aren't acknowledged by jsii, so they are not
    stripped out of the compiled source, even when deprecated. These two functions
    are deprecated and reference deprecated interfaces. When running the init
    template tests against JS/TS, the tests fail with:
    
    ```
    node_modules/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-listener-rule.d.ts(110,62): error TS2304: Cannot find name 'FixedResponse'.
    node_modules/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-listener-rule.d.ts(116,68): error TS2304: Cannot find name 'RedirectResponse'.
    ```
    
    By -- on v2 only -- un-exporting the functions and inlining them in their
    secondary usages, we can effectively "strip" these functions from the JS/TS.
    njlynch committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    4dafd7d View commit details
    Browse the repository at this point in the history