feat(eks): cluster tagging (#4995) #18109

choryuidentify · 2021-12-21T01:01:54Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2021-12-21T01:01:56Z

mergify · 2022-01-10T11:41:11Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-01-10T13:00:12Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: a789023
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-01-10T13:00:35Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

robertd · 2022-01-18T16:04:07Z

@choryuidentify This doesn't really apply tags on the cluster itself... Also, I'm not seeing tags property on the constructor for the Fargate cluster.

Edit: I'm using 2.8.0. Let me check if this functionality got ported to cdk 2.x really quick.

Edit 2: Yep... it did in 2.7.0.

choryuidentify · 2022-01-18T16:33:11Z

@choryuidentify This doesn't really apply tags on the cluster itself... Also, I'm not seeing tags property on the constructor for the Fargate cluster.

Edit: I'm using 2.8.0. Let me check if this functionality got ported to cdk 2.x really quick.

Edit 2: Yep... it did in 2.7.0.

I tested it now with aws-cdk 2.8.0 ~~and @aws-cdk/aws-eks 1.139.0~~

new eks.Cluster(this, 'test-cluster', {
  version: KubernetesVersion.V1_21,
  tags: {
    "foo": "bar"
  }
})

...and looks good (I didn't deploy this but synth it)

  testcluster29C11904:
    Type: Custom::AWSCDK-EKS-Cluster
    Properties:
      ServiceToken:
        Fn::GetAtt:
          - awscdkawseksClusterResourceProviderNestedStackawscdkawseksClusterResourceProviderNestedStackResource9827C454
          - Outputs.SampleStackawscdkawseksClusterResourceProviderframeworkonEvent06FEB728Arn
      Config:
        version: "1.21"
        roleArn:
          Fn::GetAtt:
            - testclusterRoleF0736E25
            - Arn
        resourcesVpcConfig:
          subnetIds:
            - Ref: testclusterDefaultVpcPublicSubnet1Subnet0CB1FE0A
            - Ref: testclusterDefaultVpcPublicSubnet2Subnet2D94C923
            - Ref: testclusterDefaultVpcPrivateSubnet1Subnet570845A0
            - Ref: testclusterDefaultVpcPrivateSubnet2Subnet7AFA8EC9
          securityGroupIds:
            - Fn::GetAtt:
                - testclusterControlPlaneSecurityGroupC4E3812B
                - GroupId
          endpointPublicAccess: true
          endpointPrivateAccess: true
        tags:
          foo: bar

~~Did you upgrade @aws-cdk/aws-eks of the project?~~

robertd · 2022-01-18T17:36:24Z

@choryuidentify I'm using cdk 2.8.0 ... and I'm seeing tags being propagated to Custom::AWSCDK-EKS-Cluster. Given that tags are supported on AWS::EKS::Cluster... something tells me that the custom resource doesn't propagate them properly.

choryuidentify · 2022-01-19T00:54:41Z

@robertd

I tested it using CDK 2.8.0. It deployed with tags successfully.

**EDIT: sorry, I misunderstood. CDK 2 was completely changed dependencies path.
No need to install / upgrade @aws-cdk/aws-eks module because it's CDK 1. remove wrong texts.

I don't get it. It looks not an issue of this patch.
Maybe reinstall cdk / recreate project / bootstrap cdk into your account again can be help you.

package.json

{
  "name": "testcdk",
  "version": "0.1.0",
  "bin": {
    "testcdk": "bin/testcdk.js"
  },
  "scripts": {
    "build": "tsc",
    "watch": "tsc -w",
    "test": "jest",
    "cdk": "cdk"
  },
  "devDependencies": {
    "@types/jest": "^26.0.10",
    "@types/node": "10.17.27",
    "aws-cdk": "2.8.0",
    "jest": "^26.4.2",
    "ts-jest": "^26.2.0",
    "ts-node": "^9.0.0",
    "typescript": "~3.9.7"
  },
  "dependencies": {
    "aws-cdk-lib": "2.8.0",
    "constructs": "^10.0.0"
  }
}

testcdk-stack.ts

import { Stack, StackProps } from 'aws-cdk-lib';
import * as eks from 'aws-cdk-lib/aws-eks';
import { KubernetesVersion } from 'aws-cdk-lib/aws-eks';
import { Construct } from 'constructs';

export class TestcdkStack extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    new eks.Cluster(this, "testCluster", {
      version: KubernetesVersion.V1_21,
      defaultCapacity: 0,
      tags: {
        "foo": "bar",
        "and": "more",
        'other': 'tags'
      }
    })
  }
}

Result

robertd · 2022-01-19T01:40:04Z

I’m using projen. But I’ll try using CDK directly. Also I noticed in your package.json you’re using 2.8.0 for CDK and and 1.139.0 for eks module.

…

On Tue, Jan 18, 2022 at 5:54 PM Choryu Park ***@***.***> wrote: @choryuidentify <https://github.com/choryuidentify> I'm using cdk 2.8.0 ... and I'm seeing tags being propagated to Custom::AWSCDK-EKS-Cluster. Given that tags are supported on AWS::EKS::Cluster <https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-cluster.html>... something tells me that the custom resource doesn't propagate them properly. I tested it latest CDK and library. It deployed with tags successfully. Please double check your ***@***.***/aws-eks' version inside NPM 'package.json'. CDK version and other module's version are can be different, because module versions are not following CDK version. package.json { "name": "testcdk", "version": "0.1.0", "bin": { "testcdk": "bin/testcdk.js" }, "scripts": { "build": "tsc", "watch": "tsc -w", "test": "jest", "cdk": "cdk" }, "devDependencies": { ***@***.***/aws-eks": "^1.139.0", ***@***.***/jest": "^26.0.10", ***@***.***/node": "10.17.27", "aws-cdk": "2.8.0", "jest": "^26.4.2", "ts-jest": "^26.2.0", "ts-node": "^9.0.0", "typescript": "~3.9.7" }, "dependencies": { "aws-cdk-lib": "2.8.0", "constructs": "^10.0.0" } } testcdk-stack.ts import { Stack, StackProps } from 'aws-cdk-lib';import * as eks from 'aws-cdk-lib/aws-eks';import { KubernetesVersion } from 'aws-cdk-lib/aws-eks';import { Construct } from 'constructs'; export class TestcdkStack extends Stack { constructor(scope: Construct, id: string, props?: StackProps) { super(scope, id, props); new eks.Cluster(this, "testCluster", { version: KubernetesVersion.V1_21, defaultCapacity: 0, tags: { "foo": "bar", "and": "more", 'other': 'tags' } }) }} Result <https://camo.githubusercontent.com/d40fabc631d5a17a247cbad901c40bba34382e5e7419c8ae25529d1d344c36d1/68747470733a2f2f692e696d6775722e636f6d2f304d765855537a2e706e67> — Reply to this email directly, view it on GitHub <#18109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHWN6OZHCK2MHY5ET3AVLUWYDVZANCNFSM5KO652GA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

choryuidentify · 2022-01-19T01:44:53Z

@robertd Sorry, Please check my reply again in GitHub. I edited my message several times, and I removed wrong suggestion.

robertd · 2022-01-19T01:46:25Z

Ah. That makes sense. :)

…

On Tue, Jan 18, 2022 at 6:45 PM Choryu Park ***@***.***> wrote: @robertd <https://github.com/robertd> Sorry, Please check my reply again in GitHub. I edited my message several times, and I removed wrong suggestion. — Reply to this email directly, view it on GitHub <#18109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHWN572T3LDZCSR6N4ZGTUWYJR7ANCNFSM5KO652GA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertd · 2022-01-19T03:43:50Z

@choryuidentify Must be something on my end, but I'm using 2.8.0 w/ projen. Thanks for your help btw.

robertd · 2022-01-19T04:03:54Z

@choryuidentify tags started propagating after full cleanup... something got stale on my end. Thanks for your help again.

choryuidentify · 2022-01-19T04:22:02Z

Nice!

Fixes aws#4995 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 21, 2021

github-actions bot assigned otaviomacedo Dec 21, 2021

feat(eks): cluster tagging (aws#4995)

53095f5

Fixes aws#4995

choryuidentify force-pushed the dev-eks-cluster-tag branch from a96c34c to 53095f5 Compare December 21, 2021 07:05

otaviomacedo added the pr-linter/exempt-readme The PR linter will not require README changes label Jan 10, 2022

otaviomacedo approved these changes Jan 10, 2022

View reviewed changes

Merge branch 'master' into dev-eks-cluster-tag

a789023

mergify bot merged commit 304f5b6 into aws:master Jan 10, 2022

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022

feat(eks): cluster tagging (aws#4995) (aws#18109)

a245f6f

Fixes aws#4995 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

NGL321 mentioned this pull request Mar 14, 2022

(eks): EKS tags do not update if edited after initial deploy #19388

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eks): cluster tagging (#4995) #18109

feat(eks): cluster tagging (#4995) #18109

choryuidentify commented Dec 21, 2021

gitpod-io bot commented Dec 21, 2021

mergify bot commented Jan 10, 2022

aws-cdk-automation commented Jan 10, 2022

mergify bot commented Jan 10, 2022

robertd commented Jan 18, 2022 •

edited

Loading

choryuidentify commented Jan 18, 2022 •

edited

Loading

robertd commented Jan 18, 2022

choryuidentify commented Jan 19, 2022 •

edited

Loading

robertd commented Jan 19, 2022 via email

choryuidentify commented Jan 19, 2022

robertd commented Jan 19, 2022 via email

robertd commented Jan 19, 2022 •

edited

Loading

robertd commented Jan 19, 2022 •

edited

Loading

choryuidentify commented Jan 19, 2022

feat(eks): cluster tagging (#4995) #18109

feat(eks): cluster tagging (#4995) #18109

Conversation

choryuidentify commented Dec 21, 2021

gitpod-io bot commented Dec 21, 2021

mergify bot commented Jan 10, 2022

aws-cdk-automation commented Jan 10, 2022

AWS CodeBuild CI Report

mergify bot commented Jan 10, 2022

robertd commented Jan 18, 2022 • edited Loading

choryuidentify commented Jan 18, 2022 • edited Loading

robertd commented Jan 18, 2022

choryuidentify commented Jan 19, 2022 • edited Loading

robertd commented Jan 19, 2022 via email

choryuidentify commented Jan 19, 2022

robertd commented Jan 19, 2022 via email

robertd commented Jan 19, 2022 • edited Loading

robertd commented Jan 19, 2022 • edited Loading

choryuidentify commented Jan 19, 2022

robertd commented Jan 18, 2022 •

edited

Loading

choryuidentify commented Jan 18, 2022 •

edited

Loading

choryuidentify commented Jan 19, 2022 •

edited

Loading

robertd commented Jan 19, 2022 •

edited

Loading

robertd commented Jan 19, 2022 •

edited

Loading