feat(iotevents): support actions #18869

yamatatsu · 2022-02-08T13:50:03Z

This PR allow IoT Events detector model to perform actions as this documentation.
This PR is in roadmap of #17711.

With this fix, all the interfaces of the DetectorModel are now implemented! And next works is implementing expressions and actions.

The exapmle in readme became not simple, so also this PR has sorted explanation of readme.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-02-08T13:50:06Z

packages/@aws-cdk/aws-iotevents/lib/detector-model.ts

skinny85

Looks good @yamatatsu, but we need a few more iterations before we can merge this in.

Thanks for the great contribution, as always!

packages/@aws-cdk/aws-iotevents/README.md

packages/@aws-cdk/aws-iotevents/lib/state.ts

packages/@aws-cdk/aws-iotevents/test/detector-model.test.ts

packages/@aws-cdk/aws-iotevents/test/integ.detector-model.ts

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Pull request has been modified.

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

This PR creates new module for aws-iotevents. This PR will contain implementations of Detector Model action classes. About #18869 (comment) . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

This PR creates new module for aws-iotevents. This PR will contain implementations of Detector Model action classes. About aws#18869 (comment) . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

skinny85

Thanks for the contribution @yamatatsu! This is starting to take shape, but I think we need a few more iterations before we nail the final API of this 🙂.

packages/@aws-cdk/aws-iotevents/README.md

packages/@aws-cdk/aws-iotevents/lib/action.ts

packages/@aws-cdk/aws-iotevents/lib/state.ts

skinny85 · 2022-03-01T19:16:25Z

packages/@aws-cdk/aws-iotevents/lib/state.ts

@@ -150,6 +214,7 @@ function toTransitionEventsJson(transitionEvents: TransitionEvent[]): CfnDetecto
  return transitionEvents.map(transitionEvent => ({
    eventName: transitionEvent.eventName,
    condition: transitionEvent.condition.evaluate(),
+    actions: transitionEvent.actions?.map(action => action.renderActionConfig().configuration),


We should not be calling renderActionConfig() (soon called bind()) more than once, because it can have side effects, like creating Constructs.

This code will call bind() once by actions by calling DetectorModel constructor. But if a action is used in two detector models, bind() of the action will be called twice.
Is it problem?

Nope! That's exactly how it's supposed to work.

Notice that the second detector model will call bind() with different arguments than the first one.

Also, add a unit test for it, and we'll find out 🙂.

I added the test! Calling bind twice worked without errors.
Ah.. But if an action set twice to an detector model and the action grant the role something, probably same policy will be added to the role. Is it better that we control it? 🤔

Nope! Just let IAM de-duplication handle it.

packages/@aws-cdk/aws-iotevents/lib/state.ts

packages/@aws-cdk/aws-iotevents-actions/lib/lambda-invoke-action.ts

yamatatsu · 2022-03-02T12:48:33Z

I'll address the comments and revert something to keep the difference small... Sorry!

skinny85 · 2022-03-02T16:44:56Z

No worries @yamatatsu, thanks for all of your hard work on this!

Pull request has been modified.

skinny85

Looks great @yamatatsu! 2 minor comments, and we'll get this merged.

skinny85 · 2022-03-03T18:26:17Z

packages/@aws-cdk/aws-iotevents/lib/state.ts

+  scope: Construct,
+  actionBindOptions: ActionBindOptions,
+  events: Event[],
+): CfnDetectorModel.EventProperty[] | undefined {


When does this return undefined?

Ah.. It is a remnant of big refactoring..

skinny85 · 2022-03-03T18:29:57Z

packages/@aws-cdk/aws-iotevents/test/integ.detector-model.ts

    });
-    // 2st => 1st
    offlineState.transitionTo(onlineState, {
      when: iotevents.Expression.eq(
        iotevents.Expression.inputAttribute(input, 'payload.temperature'),


Can we just leave this test unchanged? We already have an integ test in the @aws-cdk/aws-iotevents-actions module, I don't think we need this too.

Pull request has been modified.

skinny85

Thanks @yamatatsu!

mergify · 2022-03-04T19:58:00Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-03-04T21:34:22Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: de801e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-03-04T21:34:39Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This PR allow IoT Events detector model to perform actions as [this documentation](https://docs.aws.amazon.com/iotevents/latest/developerguide/iotevents-supported-actions.html). This PR is in roadmap of aws#17711. ![スクリーンショット 2022-02-08 22 43 33](https://user-images.githubusercontent.com/11013683/152999288-81721f15-fefb-4108-b34b-aab3f88a7ab8.png) With this fix, all the interfaces of the DetectorModel are now implemented! And next works is implementing expressions and actions. The exapmle in readme became not simple, so also this PR has sorted explanation of readme. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions bot added the @aws-cdk/aws-iotevents Related to AWS IoT Events label Feb 8, 2022

github-actions bot assigned skinny85 Feb 8, 2022

feat(iotevents): support actions

61a4bae

yamatatsu force-pushed the iotevents-actions branch from d665d82 to 61a4bae Compare February 8, 2022 13:55

yamatatsu commented Feb 8, 2022

View reviewed changes

packages/@aws-cdk/aws-iotevents/lib/detector-model.ts Outdated Show resolved Hide resolved

yamatatsu added 2 commits February 8, 2022 23:52

fix code comments

f3bdd56

remove redundant comments

940e1c7

skinny85 previously requested changes Feb 8, 2022

View reviewed changes

Update packages/@aws-cdk/aws-iotevents/README.md

5b86fa8

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

yamatatsu and others added 14 commits February 9, 2022 23:16

Update packages/@aws-cdk/aws-iotevents/README.md

7ad0532

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/README.md

a021c79

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/README.md

814e352

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/README.md

2e9bca1

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

address comments about README

a430030

Update packages/@aws-cdk/aws-iotevents/lib/event.ts

31d3516

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/state.ts

7bd8f97

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/state.ts

ebfeeb2

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/state.ts

a123666

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/state.ts

20c47d2

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/state.ts

9e67025

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/state.ts

9a62326

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

address comments

9cc9794

address comments about tests

218b91e

yamatatsu mentioned this pull request Feb 12, 2022

feat(iotevents): create new module for IoT Events actions #18956

Merged

fix readme

c7e142d

yamatatsu added 2 commits February 18, 2022 08:58

Merge branch 'master' into iotevents-actions

9d7abc3

add sns action

297e3b1

yamatatsu added 5 commits February 28, 2022 22:56

lambda actions

8e4452b

write readme

6d80f69

add test for coverage

011f1eb

Merge branch 'master' into iotevents-actions

a8e6fd0

write readme

b686021

yamatatsu requested a review from skinny85 March 1, 2022 12:50

skinny85 previously requested changes Mar 1, 2022

View reviewed changes

address comments

369562d

documentation

9f7ddf7

yamatatsu requested a review from skinny85 March 3, 2022 14:34

skinny85 previously requested changes Mar 3, 2022

View reviewed changes

yamatatsu added 2 commits March 4, 2022 10:03

address commits

c0ccdf8

add link of actions to README

f9b8d8c

test behavior of action

ea3059d

yamatatsu requested a review from skinny85 March 4, 2022 04:11

skinny85 approved these changes Mar 4, 2022

View reviewed changes

Merge branch 'master' into iotevents-actions

de801e0

mergify bot merged commit e01654e into aws:master Mar 4, 2022

yamatatsu deleted the iotevents-actions branch March 9, 2022 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iotevents): support actions #18869

feat(iotevents): support actions #18869

yamatatsu commented Feb 8, 2022

gitpod-io bot commented Feb 8, 2022

skinny85 left a comment

skinny85 left a comment

skinny85 Mar 1, 2022

yamatatsu Mar 3, 2022

skinny85 Mar 3, 2022

skinny85 Mar 3, 2022

yamatatsu Mar 4, 2022 •

edited

Loading

skinny85 Mar 4, 2022

yamatatsu commented Mar 2, 2022

skinny85 commented Mar 2, 2022

skinny85 left a comment

skinny85 Mar 3, 2022

yamatatsu Mar 4, 2022 •

edited

Loading

skinny85 Mar 3, 2022

skinny85 left a comment

mergify bot commented Mar 4, 2022

aws-cdk-automation commented Mar 4, 2022

mergify bot commented Mar 4, 2022

feat(iotevents): support actions #18869

feat(iotevents): support actions #18869

Conversation

yamatatsu commented Feb 8, 2022

gitpod-io bot commented Feb 8, 2022

skinny85 left a comment

Choose a reason for hiding this comment

skinny85 left a comment

Choose a reason for hiding this comment

skinny85 Mar 1, 2022

Choose a reason for hiding this comment

yamatatsu Mar 3, 2022

Choose a reason for hiding this comment

skinny85 Mar 3, 2022

Choose a reason for hiding this comment

skinny85 Mar 3, 2022

Choose a reason for hiding this comment

yamatatsu Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

skinny85 Mar 4, 2022

Choose a reason for hiding this comment

yamatatsu commented Mar 2, 2022

skinny85 commented Mar 2, 2022

skinny85 left a comment

Choose a reason for hiding this comment

skinny85 Mar 3, 2022

Choose a reason for hiding this comment

yamatatsu Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

skinny85 Mar 3, 2022

Choose a reason for hiding this comment

skinny85 left a comment

Choose a reason for hiding this comment

mergify bot commented Mar 4, 2022

aws-cdk-automation commented Mar 4, 2022

AWS CodeBuild CI Report

mergify bot commented Mar 4, 2022

yamatatsu Mar 4, 2022 •

edited

Loading

yamatatsu Mar 4, 2022 •

edited

Loading