Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudfront): Add trustedSigners to V2. #19839

Merged
merged 18 commits into from
Apr 9, 2022

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Apr 8, 2022

Some services still use the deprecated trustedSigners property, which is preventing teams which depend on those services from upgrading to V2. This change adds trustedSigners back into V2, but leaves it marked as @deprecated.

Closes #19837


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi requested a review from skinny85 April 8, 2022 23:37
@gitpod-io
Copy link

gitpod-io bot commented Apr 8, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2022 23:38
@github-actions github-actions bot added the p2 label Apr 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 8, 2022
@comcalvi comcalvi self-assigned this Apr 8, 2022
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Apr 8, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 70754a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4323d26 into aws:master Apr 9, 2022
otaviomacedo pushed a commit that referenced this pull request Apr 11, 2022
Some services still use the deprecated `trustedSigners` property, which is preventing teams which depend on those services from upgrading to V2. This change adds `trustedSigners` back into V2, but leaves it marked as `@deprecated`. 

Closes #19837

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
Some services still use the deprecated `trustedSigners` property, which is preventing teams which depend on those services from upgrading to V2. This change adds `trustedSigners` back into V2, but leaves it marked as `@deprecated`. 

Closes aws#19837

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cloudfront): deprecated property prevents CDKv2 users from using trusted signers
3 participants