Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoscaling): require public subnets for associatePublicIpAddress #2077

Merged
merged 1 commit into from
Mar 26, 2019
Merged

fix(autoscaling): require public subnets for associatePublicIpAddress #2077

merged 1 commit into from
Mar 26, 2019

Commits on Mar 22, 2019

  1. fix(autoscaling): verify public subnets for associatePublicIpAddress 

    The AutoScalingGroup construct allows setting associatePublicIpAddress,
but that is pointless when you're not in a Public subnet because your
shiny public IP address will still not be routable.

Adding the check get rids of another sharp edge around EC2 networking
that people need to be aware of.

Also change the 'isPublicSubnet()' method on VPC to work with subnet IDs
instead of objects, to align better with the 'subnetIds()' function.

BREAKING CHANGE: `VpcNetwork.isPublicSubnet()` has been renamed to
`VpcNetwork.isPublicSubnetIds()`.
    @rix0rrr
    rix0rrr committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    64cd038 View commit details
    Browse the repository at this point in the history