Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): remove Instance class #2081

Merged
merged 2 commits into from
Mar 26, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/@aws-cdk/aws-rds/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

The `aws-cdk-rds` package contains Constructs for setting up RDS instances.

> Note: this package is currently quite limited, as the CDK team is focusing
> on other use cases first. If your use case is not in the list below, there is
> no use coming in to the channel to ask "how do I..." because it won't be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passive aggressive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting fed up with the same questions over and over again. But yes, this is probably not the best message to put there. Suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 you can just point to the escape hatches topic and mention that this is not complete yet.

> possible using high-level constructs. You will have to drop down to the
> CloudFormation resources layer to achieve your use case.
>
> If you would like to help improve the state of this library, Pull Requests are welcome.

Supported:

* Clustered databases
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-rds/lib/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export * from './cluster';
export * from './cluster-ref';
export * from './instance';
export * from './props';
export * from './cluster-parameter-group';
export * from './rotation-single-user';
Expand Down
9 changes: 0 additions & 9 deletions packages/@aws-cdk/aws-rds/lib/instance.ts

This file was deleted.