fix(route53): CrossAccountZoneDelegationRecord does not remove old NS… #21599
Conversation
… records when the zoneName changes
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
|
||
| // DELETE old Resources | ||
| try { | ||
| const oldResourceProps = event.OldResourceProperties as unknown as ResourceProperties; |
There was a problem hiding this comment.
Should we only process the delete if the hosted zone or record name changes? I'm a little worried about deleting records when it is not absolutely necessary.
There was a problem hiding this comment.
I think we should only delete the old NS record when the DelegatedZoneName of the OldResourceProperties is different from the one from the (new) ResourceProperties. Otherwise we'll be removing and recreating the same record after every 'Update' event which is not necessary and might also produce outages.
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
This PR modifies the logic in the cross account zone delegation handler for handling update events. The prior code did not clean up old delegated entries.
This closes #21249
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license