Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (aws-lambda): Write multiasset function to select diffrent folders as lambda asset #21644

Closed
wants to merge 2 commits into from

Conversation

ahzia
Copy link

@ahzia ahzia commented Aug 17, 2022

Motivation: Right now in order to define a lambda function you need to set where the code resides, e.g. code: lambda.Code.asset('lambda'). Sometimes you would like to define multiple folders, for example, the actual code and node_modules, although packing can be done as a preprocessing step before actually running CDK deploy, it would be cleaner to do it as part of the lambda configuration.
This was future was requested by many users in Issue 984
Design aspect:
added a new function fromMultiAsset which takes an array of paths and archives it inside a zip file, then it calls AssetCode() and passes this new file.
The codes for Archive functions come from how it been done in cdk-assets Package

closes #984

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 17, 2022

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Aug 17, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 17, 2022 16:18
@ahzia ahzia changed the title write multi asset function feat (aws-lambda): Write multiasset function to select diffrent folders as lambda asset Aug 19, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 55250e8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 17, 2022
@kai-ten
Copy link

kai-ten commented Oct 26, 2022

@ahzia , need any help getting this to the finish line? This is a great feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lambda] specify multiple folders as a single lambda asset
3 participants