Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-rds): add logGroups properties #21678

Closed

Conversation

mokonist
Copy link
Contributor

Added logGroups(ILogGroups[]) property in DatabaseInstanceNew
fixes #20358


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2022

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Aug 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 19, 2022 08:41
@mokonist mokonist changed the title feat(aws-rds): add log logGroups properties feat(aws-rds): add logGroups properties Aug 19, 2022
@mokonist mokonist force-pushed the feat/aws-rds-log-groups-properties branch from 492b6f0 to 87d50e7 Compare August 19, 2022 08:45
@mokonist mokonist force-pushed the feat/aws-rds-log-groups-properties branch from e5e003a to 7a590df Compare August 19, 2022 09:00
@mokonist mokonist marked this pull request as draft August 19, 2022 09:08
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7a590df
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is still in draft so we haven't provided a review yet, but the README update makes me feel there something not quite right with how we're returning them and/or that we need more concrete functions for getting the specific log group you're looking for.

Please make sure to take this out of draft when it's ready for review and we'll take another look.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib/aws-rds/DatabaseInstance: Get log group of cloudwatchLogsExports
3 participants