Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda-python): export poetry dependencies without hashes #22351

Merged
merged 21 commits into from
Oct 7, 2022
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c4b3482
fix(lambda-python): export poetry dependencies without hashes to prev…
a-bigelow Oct 4, 2022
9f4f8d1
Merge branch 'main' into poetry-no-hashes
a-bigelow Oct 4, 2022
c7215b9
Merge branch 'main' into poetry-no-hashes
mergify[bot] Oct 4, 2022
c3f8d12
tests(aws-lambda-python): add --without-hashes flag to expected poetr…
a-bigelow Oct 4, 2022
937aa3e
Merge branch 'poetry-no-hashes' of https://github.com/a-bigelow/aws-c…
a-bigelow Oct 4, 2022
9de3461
Merge branch 'main' into poetry-no-hashes
mergify[bot] Oct 4, 2022
d42e780
chore(aws-lambda-python): force new poetry integ test snapshots
a-bigelow Oct 5, 2022
0bf70c0
feat(aws-lambda-python): add bundling option for excluding hashes whe…
a-bigelow Oct 5, 2022
37b9af3
tests(aws-lambda-python): add unit and integ tests for poetry lambdas…
a-bigelow Oct 5, 2022
8091c49
refactor(aws-lambda-python): use static methods for packaging choices
a-bigelow Oct 6, 2022
9badf55
test(aws-lambda-python): expect packaging to match static packaging m…
a-bigelow Oct 6, 2022
bb3d524
refactor(aws-lambda-python): use an interface for PoetryPackagingProp…
a-bigelow Oct 6, 2022
0e5e4ff
Merge branch 'main' into poetry-no-hashes
mergify[bot] Oct 7, 2022
3acbcde
refactor(aws-lambda-python): reformat poetry export command
a-bigelow Oct 7, 2022
284454e
refactor(aws-lambda-python): reformat poetry export command
a-bigelow Oct 7, 2022
7ae423a
Merge branch 'poetry-no-hashes' of https://github.com/a-bigelow/aws-c…
a-bigelow Oct 7, 2022
445bf60
refactor(aws-lambda-python): use --without-hashes as default argument
a-bigelow Oct 7, 2022
d72bb87
tests(aws-lambda-python): Test for new default --without-hashes poetr…
a-bigelow Oct 7, 2022
b41369f
tests(aws-lambda-python): Update poetry function snapshots
a-bigelow Oct 7, 2022
a8ee8d0
fix prop name on Packaging.fromEntry()
a-bigelow Oct 7, 2022
8223c70
Merge branch 'main' into poetry-no-hashes
mergify[bot] Oct 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-lambda-python/lib/packaging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class Packaging {
public static readonly POETRY = new Packaging({
dependenciesFile: DependenciesFile.POETRY,
// Export dependencies with credentials avaiable in the bundling image.
exportCommand: `poetry export --with-credentials --format ${DependenciesFile.PIP} --output ${DependenciesFile.PIP}`,
exportCommand: `poetry export --without-hashes --with-credentials --format ${DependenciesFile.PIP} --output ${DependenciesFile.PIP}`,
a-bigelow marked this conversation as resolved.
Show resolved Hide resolved
});

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-lambda-python/test/bundling.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ test('Bundling a function with poetry dependencies', () => {
bundling: expect.objectContaining({
command: [
'bash', '-c',
'cp -rTL /asset-input/ /asset-output/python && cd /asset-output/python && poetry export --with-credentials --format requirements.txt --output requirements.txt && python -m pip install -r requirements.txt -t /asset-output/python',
'cp -rTL /asset-input/ /asset-output/python && cd /asset-output/python && poetry export --without-hashes --with-credentials --format requirements.txt --output requirements.txt && python -m pip install -r requirements.txt -t /asset-output/python',
],
}),
}));
Expand Down