Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): buckets with SSE-KMS silently fail to receive logs #23385

Merged
merged 2 commits into from
Dec 22, 2022

Commits on Dec 18, 2022

  1. fix(s3): buckets with SSE-KMS silently fail to receive logs

    AWS S3 Server Access Logging does not support logging to buckets that
    use SSE-KMS, only to buckets without default encryption or to buckets
    that use SSE-S3. At least in some cases, this misconfiguration can be
    caught within the CDK (when logging to the same bucket or when the
    target bucket is using a KMS CMK).
    
    This will still fail to catch scenarios where the target bucket is using
    SSE-KMS using a KMS-managed key because the `encryptionKey` property is
    not set on the Bucket in that scenario.
    
    This may be a breaking change for some users; what is currently a mostly
    silent misconfiguration will become an error when synthesizing.
    laurelmay committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    4e8f26d View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Configuration menu
    Copy the full SHA
    ace683d View commit details
    Browse the repository at this point in the history