-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design(aws-ecs): Design doc for creating a scheduled ecs task construct #2363
Conversation
Updated the doc with feedback addressed |
Overall LGTM, I only have nit-picks that doesn't block implementation |
@awslabs/aws-cdk-team can you please review and merge in the doc? |
Merging as part of: #2336 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to decouple the “scheduling” aspect from the task. If a user wishes to execute an ECS task by publishing into an SNS topic for example or as a result of some other CW event rule, what’s their path? I imagined an API where you can simply use an ECS task as an event rule target, which indirectly means that you can also execute it on schedule by simply creating an event rule with a schedule, similarly to Lambda.
That sounds like a lower level construct,
Are you thinking about a construct that accepts an existing task definition, instead of constructing a task def or to be able to schedule using different methods (CW Events, SNS events, etc)? The purpose of this construct is to allow customers to create scheduled tasks using cw events (create new tasks, not using existing tasks). |
To me it sounds like @eladb's suggestion already exists at the L2 level with ecs.Ec2EventRuleTarget: I agree with @pkandasamy91: this is intended to be a higher-level construct to make it super simple to do a scheduled task. Most ECS users triggering a task with CloudWatch Events are doing it on a schedule. |
Got it. Thanks for the clarification |
Initial Design Doc for a new Scheduled ECS Task Construct
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.