fix(redshift): tables were dropped on table name change

[Rizxcviii]

Upon a refactor of the UserTablePrivilieges now using tableId to record changes, this fix will essentially allow table names to be changed.

Closes #24246.

BREAKING CHANGE: Further updates of the Redshift table will fail for existing tables, if the table name is changed. Therefore, changing the table name for existing Redshift tables have been disabled.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[scanlonp]

@Rizxcviii thanks for all of your responses! I will take another pass over the code with your comments & updates in mind, but I felt pretty good about it before. Since this module is still in alpha, I do not believe we will need a feature flag; we can just go with the new default behavior. But I will put some more thought into it.

My last request is confirmation that the update functionality works as intended. I put some more details in the integ test comment from my last review (essentially our testing cannot handle update behavior)!

[Rizxcviii]

@scanlonp after testing locally, I discovered a fault. Which was assuming Data attributes are sent across requests. This is not the case, and there does not seem to be a way to move tableName between deployments other than through the OldResourceProperties object.

Given that you do not feel we need a feature flag for this construct, I can continue to work on this change. The caveat is previously created tables will no longer be able to update their tables, if they were to change their table name.

[scanlonp]

@Rizxcviii, glad you found that!
So the new behavior will be that if someone has an existing table, and they redeploy with a new name, that table will no longer be able to be updated?
Any this does not apply to any other scenario? i.e. newly created table -> change table name?

[Rizxcviii]

@Rizxcviii, glad you found that!
So the new behavior will be that if someone has an existing table, and they redeploy with a new name, that table will no longer be able to be updated?

Yes existing tables will no longer be able to be updated. I'm going to change it so existing tables cannot change their table names.

Any this does not apply to any other scenario? i.e. newly created table -> change table name?

No, new tables can change their table name as they please

[Rizxcviii]

@scanlonp

These were taken from a local deployment. This may be confusing, but new_test_table_v2 is actually the initial table. And that gets changed to old_test_table_v2

[Rizxcviii]

@scanlonp could you take a look at this PR please? Thank you

[scanlonp]

This looks great. I think all the code is good. From your screen shots, we are getting the behavior we want with replacing the prefix in the name.

Last request is adding a couple lines in the readme about this behavior. It will be quite annoying for a user to try to figure out what is happening to their table by looking up this pull instead of seeing a blurb in the docs.

After that we can get this merged!

Pull request has been modified.

[scanlonp]

Thanks for getting this in!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: eaa7285
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).