Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): hide diffs of mangled unicode strings #24557

Closed
wants to merge 2 commits into from
Closed

fix(cli): hide diffs of mangled unicode strings #24557

wants to merge 2 commits into from

Commits on Mar 9, 2023

  1. fix(cli): hide diffs of mangled unicode strings 

    CloudFormation's `GetStackTemplate` irrecoverably mangles any character
not in the 7-bit ASCII range. This causes noisy output from `cdk diff`
when a template contains non-English languages or emoji. We can detect
this case and consider these strings equal.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @laverdet
    laverdet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1796a8e View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @laverdet
    laverdet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8f20a23 View commit details
    Browse the repository at this point in the history