-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codepipeline-actions): correctly serialize the userParameters pas… #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
May 14, 2019
skinny85
force-pushed
the
fix/lambda-invoke-action
branch
from
May 23, 2019 23:44
7e8b239
to
fb7548a
Compare
eladb
suggested changes
May 24, 2019
packages/@aws-cdk/aws-codepipeline-actions/lib/lambda/invoke-action.ts
Outdated
Show resolved
Hide resolved
skinny85
force-pushed
the
fix/lambda-invoke-action
branch
from
May 24, 2019 16:04
fb7548a
to
c63b604
Compare
rix0rrr
approved these changes
May 28, 2019
@eladb do you have any more comments on this PR? |
eladb
approved these changes
May 29, 2019
packages/@aws-cdk/aws-codepipeline-actions/test/lambda/test.lambda-invoke-action.ts
Outdated
Show resolved
Hide resolved
…sed to the Lambda invoke Action. BREAKING CHANGE: removed the `addPutJobResultPolicy` property when creating LambdaInvokeAction.
skinny85
force-pushed
the
fix/lambda-invoke-action
branch
from
May 29, 2019 22:52
c63b604
to
6d46dbf
Compare
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sed to the Lambda invoke Action.
BREAKING CHANGE: removed the
addPutJobResultPolicy
property when creating LambdaInvokeAction.Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.