-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(servicecatalog): Make possible to have assets in several products… #25402
Conversation
… in the same portfolio (aws#25189)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Hi Aws Cdk Team and @statik @ktheory @pfeilbr (hopefully I mentioned right persons, sorry if not) ! Could you please run integration test for me? When I am doing it on my own, I am getting this error (region seems to be set in env variables):
But I deployed stack manually and it has worked. Thank you in advance! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
fix(servicecatalog): Make possible to have assets in different products in the same portfolio (#25189)
Currently it's not possible to have assets (ex. lambdas) in different products in the same portfolio. The reason for that is that asset bucket will be deployed
within the portfolio stack and name for its deployment is hardcoded what leads to the exception 'There is already a Construct with name' at synth step.
Closes #25189
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license