feat(synthetics): support runtime nodejs puppeteer 4.0 #25553
Conversation
…at/synthetics/support-runtime-puppeteer-4.0
github-actions
bot
added
the
admired-contributor
|
|
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
This blueprint was renewed in AWS Synthetics service console and failed run, so I replaced this script to latest script.
| conn.close() | ||
|
|
||
|
|
||
| def main(): | ||
|
|
||
| url = 'https://example.com/' | ||
| url = os.environ['URL'] |
There was a problem hiding this comment.
I changed this dummy url to actual URL that created in integ test stack.
| // Assertion that all Canary's are Passed | ||
| [ | ||
| inlineAsset, | ||
| directoryAsset, | ||
| zipAsset, | ||
| puppeteer39, | ||
| puppeteer40, | ||
| selenium13, | ||
| ].forEach((canary) => test.assertions | ||
| .awsApiCall('Synthetics', 'getCanaryRuns', { | ||
| Name: canary.canaryName, | ||
| }) | ||
| .assertAtPath('CanaryRuns.0.Status.State', ExpectedResult.stringLikeRegexp('PASSED')) | ||
| .waitForAssertions({ totalTimeout: cdk.Duration.minutes(5) })); |
There was a problem hiding this comment.
This assertion can test that status of canaries is passed.
There was a problem hiding this comment.
This blueprint was renewed in AWS Synthetics service console and failed run, so I replaced this script to latest script.
There was a problem hiding this comment.
what do you mean by this? does the old canary runtime code not work? We intentionally did not use AWS Synthetics blueprints because we don't want to be in charge of making sure that our copy is the same as the blueprint.
If the current code fails, i would prefer to fix it in the most basic way possible than replace it with the actual blueprint.
There was a problem hiding this comment.
Yes. old canary runtime code was not work. I got failed status.
However, I understood your think, so I changed runtime code to close to minimum changes.
github-actions
bot
added
effort/small
There was a problem hiding this comment.
what do you mean by this? does the old canary runtime code not work? We intentionally did not use AWS Synthetics blueprints because we don't want to be in charge of making sure that our copy is the same as the blueprint.
If the current code fails, i would prefer to fix it in the most basic way possible than replace it with the actual blueprint.
|
Thanks @kaizencc for your reviewing! |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
What change
Add CloudWatch Synthetics runtime nodejs puppeteer 4.0.
Others
I changed integ test to using integ-tests assertions.
Closes #25493
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license