fix(batch): computeEnvironmentName is not set in FargateComputeEnvironment

[akshaypilankar]

computeEnvironmentName property was missing in FargateComputeEnvironment due to which ComputeEnvironmentName property set on the resulting AWS::Batch::ComputeEnvironment resource in the outputted CloudFormation.
Updated managed-compute-environment to reflect the fix made in FargateComputeEnvironment.

Closes #25794.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[akshaypilankar]

Exemption Request - Existing testcases are sufficient to test this small change in parameter.

[akshaypilankar]

Clarification Request - Existing testcases are sufficient for the new changes.

[peterwoodworth]

Existing testcases are sufficient for the new changes

It looks like you've gone ahead and tried to work on tests since this, so thanks 🙂

You'll need to run the integration tests and update their snapshots, currently only the file has been adjusted, we need to verify that the integration tests still deploy.

[akshaypilankar]

Hey @peterwoodworth, I am not able to run integration tests on my end. Is there any way we can skip the testcases since it is not required in this scenario?

[peterwoodworth]

We should be testing that every property gets synthesized and that deployment works - since we aren't currently doing that, test cases are required.

I am not able to run integration tests on my end

What's preventing you from running integration tests?

[akshaypilankar]

What's preventing you from running integration tests?
Not able to build framework-integ

[comcalvi]

thanks for the fix, this is almost ready to merge. We definitely need changes to the integration test snapshots here, because you've (correctly) changed the integ test file. Just remove the taggedFargate resource and I can update the snapshots for you.

[comcalvi]

you don't need to add this here, you already added it to the CE above.

[akshaypilankar]

Hey @comcalvi, Thank you so much for the help. Please update the snapshots.

[comcalvi]

sigh...I broke it. Sorry about this. Please do not pull from the remote.

I ran git push your-fork main and that didn't work, added a -f to it, and that pushed my main branch to yours, which is not what I wanted; it set your main back to it. For some reason I can push my main to your main, but I can't push the branch that has the actual snapshots on it; that gives a permission denied error.

Can you ensure maintainers are allowed to push to your fork?

This also shouldn't be closed...not sure why it was closed

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: d754c37
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[akshaypilankar]

@comcalvi 😓 I am also not sure why is it closed. I guess they have merged the changes from some other PR 😞

[comcalvi]

Can you push some code to branch of this PR @akshaypilankar, so I can reopen it? 🙂
The issue hasn't been fixed yet, and no other PR was merged; this one was closed by mistake and it can't be reopened until you push your main branch, because I accidentally deleted your commits on that branch.

So don't pull from the branch, instead do a force push to your main.

[akshaypilankar]

@comcalvi Here is the new PR - #25944