-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step #25413 #25852
Conversation
…ve level. Further added the possibility to set all prepare nodes at first in a stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
@rix0rrr I have created some new integ tests for the pipelines construct. Since the cdk-pipelines-demo repo is private, i cannot generate the snapshots. Can you please run the tests? |
@hoegertn Here is the new pr |
@rix0rrr Could you also please rerun the integ tests which are failing because of a change to the naming of the prepare-steps |
Exemption Request: |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Nico db patch 1
removed multi empty line
remove empty lines
removed empty lines
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This should stay open. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Describe the feature
I would like to "run" all changesets of a stage at first, then have a manual approval step and then perform the execute change set in the original run-order.
Use Case
The use case is, that we would like to check the changesets for all stacks of an environment, to be able to perform a qualified manual approval.
Closes #24072.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license