fix(glue): support Ray jobs with Runtime parameter #25867
Conversation
|
|
github-actions
bot
added
p2
beginning-contributor
| /** | ||
| * Ray 2.4 | ||
| */ | ||
| RAY_TWO_FOUR = 'Ray2.4', |
There was a problem hiding this comment.
This would be a repetitive operation, wondering if we want to move away from enums
There was a problem hiding this comment.
should be an enum-like class:
export class Runtime {
public static RAY_TWO_FOUR = new Runtime('Ray2.4');
public constructor(public readonly runtime: string) {}
}There was a problem hiding this comment.
Thanks for sharing the example. Reflected with minor change.
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Thanks for getting started on this @moomindani! Some minor comments
| /** | ||
| * Ray 2.4 | ||
| */ | ||
| RAY_TWO_FOUR = 'Ray2.4', |
There was a problem hiding this comment.
should be an enum-like class:
export class Runtime {
public static RAY_TWO_FOUR = new Runtime('Ray2.4');
public constructor(public readonly runtime: string) {}
}| @@ -150,6 +160,12 @@ interface PythonExecutableProps { | |||
| } | |||
|
|
|||
| interface SharedJobExecutableProps { | |||
| /** | |||
| * Runtime. | |||
There was a problem hiding this comment.
stronger docs needed. need to know when is runtime required, etc
There was a problem hiding this comment.
Added bit more information.
Our public doc does not have much information about this property, but I tried to add as much as possible.
| @@ -388,6 +407,13 @@ export interface JobExecutableConfig { | |||
| */ | |||
| readonly pythonVersion?: PythonVersion; | |||
|
|
|||
| /** | |||
| * The Runtime to use. | |||
There was a problem hiding this comment.
Our public doc does not have much information about this property, but I tried to add as much as possible.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS Glue recently changed API and CloudFormation spec to require
Runtimeparameter for Ray jobs.To address the changes, I am submitting this PR.
This PR is for fixing the issue #25787.
Reference
CloudFormation doc has been also updated for
Runtimeparameter.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-job-jobcommand.html#cfn-glue-job-jobcommand-runtime
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license