-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update alpha modules to sdk v3 #25895
Conversation
`@aws-sdk/types` dependency is required with a version locked to our `@aws-sdk/*` client libraries used in testing, otherwise type conflicts can occur at the mono-repo level.
…to feat/alpha-modules-sdk-v3
packages/@aws-cdk/aws-amplify-alpha/lib/asset-deployment-handler/handler.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update all the integ test that use these custom resources to
have diffAssets: true
so that we have to rerun the integ tests.
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/base.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/providers/lambda-handler/sdk.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/lib/assertions/providers/lambda-handler/sdk.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Cory Hall <43035978+corymhall@users.noreply.github.com>
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Updates alpha modules with custom resources to use NodeJS 18 and v3 of the AWS SDK. Since these CRs are pretty self-contained and safe to update, their handler code and runtime versions can be updated without any breakage for users.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license