Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update alpha modules to sdk v3 #25895

Merged
merged 18 commits into from
Jun 30, 2023
Merged

feat: update alpha modules to sdk v3 #25895

merged 18 commits into from
Jun 30, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

Updates alpha modules with custom resources to use NodeJS 18 and v3 of the AWS SDK. Since these CRs are pretty self-contained and safe to update, their handler code and runtime versions can be updated without any breakage for users.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`@aws-sdk/types` dependency is required with a version locked to our
`@aws-sdk/*` client libraries used in testing, otherwise type conflicts
can occur at the mono-repo level.
@MrArnoldPalmer MrArnoldPalmer added the pr-linter/exempt-readme The PR linter will not require README changes label Jun 7, 2023
@gitpod-io
Copy link

gitpod-io bot commented Jun 7, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 7, 2023 22:07
@github-actions github-actions bot added the p2 label Jun 7, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 7, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 9, 2023
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update all the integ test that use these custom resources to
have diffAssets: true so that we have to rerun the integ tests.

@corymhall corymhall removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2023
@MrArnoldPalmer MrArnoldPalmer requested a review from corymhall June 29, 2023 19:30
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c7de0b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0a4140e into main Jun 30, 2023
@mergify mergify bot deleted the feat/alpha-modules-sdk-v3 branch June 30, 2023 17:05
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants