chore: Remove npm bin from scripts

[douglasnaphas]

This change removes the expression export PATH=$(npm bin):$PATH, which had formerly been used in scripts to ensure node_modules is in PATH.

npm bin was removed in npm 9. npm exec or npx should be used instead. build.sh already uses npx. This change revises scripts/gen.sh to use npx as well.

Prior to this change, within shells executing build.sh or scripts/gen.sh, PATH actually contains error text if npm 9+ is used.

~/repos/aws-cdk $ docker run --rm -v $PWD:$PWD -w $PWD node:hydrogen-alpine sh -c 'node --version && npm --version && export PATH=$(npm bin):$PATH && echo $PATH' # output when npm bin is unavailable
v18.16.0
9.5.1
Unknown command: "bin" To see a list of supported npm commands, run: npm help:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

~/repos/aws-cdk $ docker run --rm -v $PWD:$PWD -w $PWD node:gallium-alpine sh -c 'node --version && npm --version && export PATH=$(npm bin):$PATH && echo $PATH' # output when npm bin is available
v16.20.0
8.19.4
/Users/douglasnaphas/repos/aws-cdk/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

It didn't make build.sh fail, because lerna has been run via npx since #24217, and build.sh doesn't need anything from node_modules to be added to PATH. export PATH=$(npm bin):$PATH succeeds even though npm bin fails, per export's normal behavior.

Prior to this change, scripts/gen.sh failed with

./scripts/gen.sh: line 18: lerna: command not found

when I ran it. After this change, scripts/gen.sh ran successfully.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 415dc20
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).