Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): v2.83.1 #25914

Merged
merged 2 commits into from
Jun 9, 2023
Merged

chore(release): v2.83.1 #25914

merged 2 commits into from
Jun 9, 2023

Commits on Jun 9, 2023

  1. fix(cli): assets shared between stages lead to an error (#25907) 

    The problem would manifest as this error message:

```
❌ Deployment failed: Error: Duplicate use of node id: 07a6878c7a2ec9b49ef3c0ece94cef1c2dd20fba34ca9650dfa6e7e00f2b9961:current_account-current_region-build
```

The problem was that we were using the full asset "destination identifier" for both the build and publish steps, but then were trying to use the `source` object to deduplicate build steps.

A more robust solution is to only use the asset identifier (excluding the destination identifier) for the build step, which includes all data necessary to deduplicate the asset. No need to look at the source at all anymore.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @rix0rrr
    rix0rrr committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    68ed8ca View commit details
    Browse the repository at this point in the history

  2. chore(release): 2.83.1

    @rix0rrr
    rix0rrr committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d6c914b View commit details
    Browse the repository at this point in the history