Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudfront): avoid to sort TTLs when using Tokens in CachePolicy #25920

Merged
merged 6 commits into from
Jun 14, 2023
Merged

fix(cloudfront): avoid to sort TTLs when using Tokens in CachePolicy #25920

merged 6 commits into from
Jun 14, 2023

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Jun 9, 2023

Closes #25795.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 9, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jun 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 9, 2023 11:08
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jun 9, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Tietew

This comment was marked as outdated.

Sign in to view
@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 9, 2023
@Tietew Tietew changed the title fix(cloudfront): avoid to sort tokened TTLs in CachePolicy fix(cloudfront): avoid to sort TTLs when using Tokens in CachePolicy Jun 9, 2023
@Tietew Tietew mentioned this pull request Jun 9, 2023
Merged
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 12, 2023 11:19

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Tietew
Copy link
Contributor Author

Tietew commented Jun 12, 2023

Added integration test. I withdraw my exemption request.

@corymhall corymhall removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2023
@mergify mergify bot dismissed otaviomacedo’s stale review June 13, 2023 02:23

Pull request has been modified.

@Tietew
Copy link
Contributor Author

Tietew commented Jun 13, 2023

@otaviomacedo Thanks for review! I added a test.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 13, 2023
mergify bot pushed a commit that referenced this pull request Jun 13, 2023
@Tietew
fix(autoscaling): AutoScalingGroup maxCapacity defaults to minCapacit…
3bd973a 
…y when using Token (#25922)

Related to #25920.

In `AutoScalingGroup`, `maxCapacity` defaults to `Math.max(minCapacity, 1)` even when `minCapacity` is a Token.
Because Token number is always negative number, `maxCapacity` will be set to `1` when `maxCapacity` is `undefined` and `minCapacity` is a Token.

see also #25795 (comment)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@Tietew Tietew requested a review from otaviomacedo June 14, 2023 01:32
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e12db0a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bc80331 into aws:main Jun 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Tietew Tietew deleted the cf-cachepolicy-ttl-token branch June 14, 2023 14:22
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@otaviomacedo otaviomacedo

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib.aws_cloudfront): CachePolicy TTL value from SSM parameter not resolved correctly
4 participants
@Tietew @aws-cdk-automation @otaviomacedo @corymhall