Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add deprecation note to all packages in v1 #25957

Merged
merged 7 commits into from
Jun 14, 2023
Merged

chore: add deprecation note to all packages in v1 #25957

merged 7 commits into from
Jun 14, 2023

Conversation

RomainMuller
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 13, 2023

@github-actions github-actions bot added the p2 label Jun 13, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 13, 2023 09:19
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 13, 2023
rix0rrr
rix0rrr previously approved these changes Jun 13, 2023
View reviewed changes
@RomainMuller RomainMuller added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules pr-linter/exempt-integ-test The PR linter will not require integ test changes pr/do-not-merge This PR should not be merged at this time. labels Jun 13, 2023
@RomainMuller RomainMuller dismissed rix0rrr’s stale review June 13, 2023 12:28

Realized it can't be done like this

@RomainMuller RomainMuller force-pushed the rmuller/deprecate-v1 branch from a90c06c to 94edd03 Compare June 13, 2023 13:33
@RomainMuller RomainMuller force-pushed the rmuller/deprecate-v1 branch from da91914 to ca5800c Compare June 14, 2023 10:42
@RomainMuller RomainMuller removed the pr/do-not-merge This PR should not be merged at this time. label Jun 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 22d8a2f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller RomainMuller merged commit d3f6a86 into v1-main Jun 14, 2023
@RomainMuller RomainMuller deleted the rmuller/deprecate-v1 branch June 14, 2023 15:17
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainMuller @aws-cdk-automation @rix0rrr