Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): support s3 bucket double encryption mode aws:kms:dsse (… #25961

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

comcalvi
Copy link
Contributor

Adding support for the new encryption mode DSSE (aws:kms:dsse). DSSE is a new encryption mode which does double encryption with the kms generated data key.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…151)

Adding support for the new encryption mode DSSE (aws:kms:dsse). DSSE is a new encryption mode which does double encryption with the kms generated data key.

Co-authored-by: Yuandong-Chen <zyz2118acz@gwmail.gwu.edu>
@gitpod-io
Copy link

gitpod-io bot commented Jun 13, 2023

@github-actions github-actions bot added the p2 label Jun 13, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 13, 2023 16:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 13, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@comcalvi comcalvi changed the title feat(aws-s3): support s3 bucket double encryption mode aws:kms:dsse (… feat(s3): support s3 bucket double encryption mode aws:kms:dsse (… Jun 13, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 13, 2023 17:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit df263a6 into main Jun 13, 2023
@mergify mergify bot deleted the s3 branch June 13, 2023 18:55
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 40e33c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants