Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cx-api): feature flags are documented incorrectly #25994

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

kaizencc
Copy link
Contributor

//  !!! IMPORTANT !!!
//
//  When you introduce a new flag, set its 'introducedIn.v2' value to the literal string
// 'V2·NEXT', without the dot.
//
//  DO NOT USE A VARIABLE. DO NOT DEFINE A CONSTANT. The actual value will be string-replaced at
//  version bump time.

Well, this proved to be difficult. Some places we supplied V2·NEXT, with the dot. This PR manually updates everything back to when they were released, because we've missed the boat on the magic V2NEXT updates.

cc @corymhall for visibility, since you and I were the culprits and I was copying you :)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2023 15:47
@github-actions github-actions bot added the p2 label Jun 15, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e560f7f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 83dc73c into main Jun 15, 2023
@mergify mergify bot deleted the conroy/feature-flag-mishap branch June 15, 2023 16:39
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants