fix(rds): monitoring role is not created by default when using readers and writers #26006
Conversation
|
|
github-actions
bot
added
the
admired-contributor
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request. |
aws-cdk-automation
added
pr-linter/exemption-requested
|
Finally, was this solution included in a service pack ? |
| const instanceEndpoints: Endpoint[] = []; | ||
| const instanceIdentifiers: string[] = []; | ||
| const readers: IAuroraClusterInstance[] = []; | ||
|
|
||
| let monitoringRole = props.monitoringRole; |
There was a problem hiding this comment.
Can we move this into
?There was a problem hiding this comment.
👍 should be good now
aws-cdk-automation
removed
the
pr/needs-community-review
| @@ -1602,7 +1602,7 @@ describe('cluster', () => { | |||
| Template.fromStack(stack).hasResourceProperties('AWS::RDS::DBInstance', { | |||
| MonitoringInterval: 60, | |||
| MonitoringRoleArn: { | |||
| 'Fn::GetAtt': ['DatabaseMonitoringRole576991DA', 'Arn'], | |||
| 'Fn::GetAtt': ['DatabasewriterMonitoringRole23A1E3B6', 'Arn'], | |||
There was a problem hiding this comment.
ahh sorry I missed what was going on here. You had it right initially. If we move it to AuroraClusterInstance then we will create a role per instance which is not what we want 🤦♂️
There was a problem hiding this comment.
👍 no problem, I reverted it to the original version
corymhall
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The
_createInstancesfunction was not providing a defaultmonitoringRolevalue with enabled monitoring.This fix creates a default role as done by the legacy code.
Closes #25941.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license