Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint-plugin): linter chokes on aws-cdk-lib/core import #26022

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

kaizencc
Copy link
Contributor

#25802 changed imports in alpha modules from aws-cdk-lib to aws-cdk-lib/core.

Not sure how that got past the linter in the first place, but my linter is choking on this because aws-cdk-lib/core does not have a package.json.

Error: ENOENT: no such file or directory, open '<path>/aws-cdk/packages/aws-cdk-lib/core/package.json'

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2023

@kaizencc kaizencc changed the title chore(eslint-plugin): linter chokes on aws-cdk-lib/core chore(eslint-plugin): linter chokes on aws-cdk-lib/core import Jun 16, 2023
@github-actions github-actions bot added the p2 label Jun 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2023 22:42
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 16, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 901ffa6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a278fa7 into main Jun 19, 2023
@mergify mergify bot deleted the kaizencc-patch-8 branch June 19, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants