-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rds): Add support for RDS MySQL minor versions of 8.0.33 and 5.7.42 #26050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
labels
Jun 20, 2023
aws-cdk-automation
added
the
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
label
Jun 20, 2023
colifran
reviewed
Jun 21, 2023
@@ -578,6 +578,8 @@ export class MysqlEngineVersion { | |||
public static readonly VER_5_7_40 = MysqlEngineVersion.of('5.7.40', '5.7'); | |||
/** Version "5.7.41". */ | |||
public static readonly VER_5_7_41 = MysqlEngineVersion.of('5.7.41', '5.7'); | |||
/** Version "5.7.42". */ | |||
public static readonly VER_5_7_42 = MysqlEngineVersion.of('5.7.42', '5.7'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colifran
reviewed
Jun 21, 2023
@@ -613,6 +615,8 @@ export class MysqlEngineVersion { | |||
public static readonly VER_8_0_31 = MysqlEngineVersion.of('8.0.31', '8.0'); | |||
/** Version "8.0.32". */ | |||
public static readonly VER_8_0_32 = MysqlEngineVersion.of('8.0.32', '8.0'); | |||
/** Version "8.0.33". */ | |||
public static readonly VER_8_0_33 = MysqlEngineVersion.of('8.0.33', '8.0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for your contribution! |
colifran
previously approved these changes
Jun 21, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
colifran
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
p2
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for RDS MySQL minor versions of 8.0.33 and 5.7.42.
https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-mysql-new-minor-versions/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license