Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): Support for CodeBuild Image aws/codebuild/amazonlinux2-x86_64-standard:5.0 #26058

Merged
merged 11 commits into from
Jul 3, 2023

Conversation

sktan
Copy link
Contributor

@sktan sktan commented Jun 20, 2023

Added support for Amazon Linux 2023 CodeBuild Image:

https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html

aws/codebuild/amazonlinux2-x86_64-standard:5.0

i.e you can now reference the latest codebuild image via the codebuild.LinuxBuildImage.AMAZON_LINUX_2_5 enum rather than having to resolve it manually like LinuxBuildImage.codeBuildImage('aws/codebuild/amazonlinux2-x86_64-standard:5.0')


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2023

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 20, 2023 15:34
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sktan
Copy link
Contributor Author

sktan commented Jun 20, 2023

Exemption Request

This is just adding a value to an enum which doesn't change any pre-existing behaviour

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jun 20, 2023
@sktan sktan changed the title feat(codebuild): Support for CodeBuild Amazon Linux 2023 Build Image feat(codebuild): Support for CodeBuild aws/codebuild/amazonlinux2-x86_64-standard:5.0 Jun 20, 2023
@sktan sktan changed the title feat(codebuild): Support for CodeBuild aws/codebuild/amazonlinux2-x86_64-standard:5.0 feat(codebuild): Support for CodeBuild Image aws/codebuild/amazonlinux2-x86_64-standard:5.0 Jun 20, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 20, 2023
@Tietew
Copy link
Contributor

Tietew commented Jun 21, 2023

The document says al2/standard/5.0 is Amazon Linux 2023.
The correct name might be AMAZON_LINUX_2023_5

@sktan
Copy link
Contributor Author

sktan commented Jun 21, 2023

The document says al2/standard/5.0 is Amazon Linux 2023. The correct name might be AMAZON_LINUX_2023_5

I did consider this actually, but ultimately went with the Image Identifier as:

  • That is the version number that's incrementing (might be confusing since the numbers won't be incrementing sequentially from 1 for future Amazon Linux distributions)
  • This identifier is shown to the user the AWS Console provides when selecting the option.

Maybe this should be revised by the codebuild team or we can just include both.

image

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 26, 2023 15:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good to me.

Tagging @corymhall to get a second opinion for the PR.

Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I synced with Cory and have some feedback. Let me know if you need any clarifications.

@vinayak-kukreja vinayak-kukreja removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jun 27, 2023
@mergify mergify bot dismissed vinayak-kukreja’s stale review June 27, 2023 23:48

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 28, 2023
@sktan
Copy link
Contributor Author

sktan commented Jun 28, 2023

@vinayak-kukreja Thanks for the comments, I've fixed it up and the new commit passed the CI tests

@sktan sktan requested a review from vinayak-kukreja June 28, 2023 05:37
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for addressing the feedback. Just some minor comments.

constructor(scope: Construct, id: string) {
super(scope, id);

/// !show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, could you also remove: /// !show and /// !hide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this too 😄

@mergify mergify bot dismissed vinayak-kukreja’s stale review June 28, 2023 22:20

Pull request has been modified.

@sktan sktan requested a review from vinayak-kukreja June 28, 2023 22:21
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution :)

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6a48e16
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bc029fe into aws:main Jul 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sktan sktan deleted the feat/aws-codebuild/amazonlinux2023 branch July 4, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants