Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integ-tests): new HttpApiCall method to easily make http calls #26102

Merged
merged 5 commits into from
Jun 26, 2023
Merged

feat(integ-tests): new HttpApiCall method to easily make http calls #26102

merged 5 commits into from
Jun 26, 2023

Conversation

corymhall
Copy link
Contributor

This PR adds a new httpApiCall method (and associated construct) that makes it easy to make assertions against the results of an http call.

I've updated a couple of existing integration tests to use this new method.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This PR adds a new `httpApiCall` method (and associated construct) that
makes it easy to make assertions against the results of an http call.

I've updated a couple of existing integration tests to use this new
method.
@gitpod-io
Copy link

gitpod-io bot commented Jun 23, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 23, 2023 14:19
@github-actions github-actions bot added the p2 label Jun 23, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 23, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 23, 2023 14:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

testCases: [testCase],
});

const call = integ.assertions.httpApiCall(`http://${testCase.lb.loadBalancerDnsName}`, { });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool! 🚀

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 73964b4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 00b9c84 into aws:main Jun 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants