fix(cdk-lib): Pass lookupRoleArn to NestedStackSynthesizer #26116
Conversation
|
|
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: an integration test coudn't be added because it would be needed of two AWS accounts to execute (so it can actually switch and use the lookup role on the target account), which will break the logic of integration tests and snapshots reproducibility. |
aws-cdk-automation
added
pr-linter/exemption-requested
|
Exemption Request: an integration test coudn't be added because it would be needed of two AWS accounts to execute (so it can actually switch and use the lookup role on the target account), which will break the logic of integration tests and snapshots reproducibility. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
|
Hi @peterwoodworth, hope you are doing great! |
aws-cdk-automation
added
the
pr/needs-community-review
corymhall
added
the
pr-linter/exempt-integ-test
corymhall
removed
the
pr/needs-community-review
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NestedStack's synthesizer doesn't receive the lookupRoleArn from the parent stack synthesizer, so the NestedStack tries with local credentials (of the deployment account) instead of assuming a cross-account role (on the target account) as regular non-nested Stack would do. This PR aims to add lookupRoleArn reference to the StackSynthesizer class and IStackSynthesizer, so it can be use on the NestedStack to explicitly set an IAM role in case of parent stack having one already defined, so CDK uses the role instead of local credentials. Closes aws#25171. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NestedStack's synthesizer doesn't receive the lookupRoleArn from the parent stack synthesizer, so the NestedStack tries with local credentials (of the deployment account) instead of assuming a cross-account role (on the target account) as regular non-nested Stack would do. This PR aims to add lookupRoleArn reference to the StackSynthesizer class and IStackSynthesizer, so it can be use on the NestedStack to explicitly set an IAM role in case of parent stack having one already defined, so CDK uses the role instead of local credentials. Closes aws#25171. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NestedStack's synthesizer doesn't receive the lookupRoleArn from the parent stack synthesizer, so the NestedStack tries with local credentials (of the deployment account) instead of assuming a cross-account role (on the target account) as regular non-nested Stack would do.
This PR aims to add lookupRoleArn reference to the StackSynthesizer class and IStackSynthesizer, so it can be use on the NestedStack to explicitly set an IAM role in case of parent stack having one already defined, so CDK uses the role instead of local credentials.
Closes #25171.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license