Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build noctilucent WASM library in a container #26123

Merged
merged 7 commits into from
Jun 28, 2023
Merged

chore: build noctilucent WASM library in a container #26123

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
647bc17
add rust dependency to contributing
Jun 26, 2023
eecf5e8
Merge branch 'main' into bobertzh/doc-update
HBobertz Jun 26, 2023
58769b2
add prerequisite check for rustup
RomainMuller Jun 27, 2023
ae51139
stop trying to regex it propertly
RomainMuller Jun 27, 2023
3609fb2
build noctilucent WASM stuff in-container
RomainMuller Jun 27, 2023
ad45f49
Merge branch 'main' into bobertzh/doc-update
HBobertz Jun 27, 2023
8ea0070
Merge branch 'main' into bobertzh/doc-update
mergify[bot] Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ The following tools need to be installed on your system prior to installing the
- [Python >= 3.6.5, < 4.0](https://www.python.org/downloads/release/python-365/)
- [Docker >= 19.03](https://docs.docker.com/get-docker/)
- the Docker daemon must also be running
- [Rust >= 1.68, rustup >= 1.25.2](https://www.rust-lang.org/tools/install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this.

How would users be informed of this change? I think an issue can be created and pinned informing the users about this, WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a prerequisite test to inform users.


First fork the repository, and then run the following commands to clone the repository locally.

Expand Down
29 changes: 29 additions & 0 deletions scripts/check-build-prerequisites.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,35 @@ else
wrong_version
fi

# Rustup
app="rustup"
app_min="1.25.2"
check_which $app $app_min
app_v=$(${app} --version 2>/dev/null | cut -d' ' -f2)
echo -e "Checking rustup version... \c"
major=$(echo ${app_v} | cut -d'.' -f1)
minor=$(echo ${app_v} | cut -d'.' -f2)
patch=$(echo ${app_v} | cut -d'.' -f3)
if [ $major -eq 1 ]
then
if [ $minor -eq 25 ]
then
if [ $patch -ge 2 ]
then
echo "Ok"
else
wrong_version
fi
elif [ $minor -gt 25 ]
then
echo "Ok"
else
wrong_version
fi
else
wrong_version
fi

# Container Client
container_client=${CDK_DOCKER:-docker}
docker_min="19.03.0"
Expand Down