chore(ec2): replace latestAmazonLinux with latestAmazonLinux2 used inside BastionHostLinux

[clueleaf]

Synthesizing BastionHostLinux generates the following warning:

[WARNING] aws-cdk-lib.aws_ec2.MachineImage#latestAmazonLinux is deprecated.
  use MachineImage.latestAmazonLinux2 instead
  This API will be removed in the next major release.

This PR replaces latestAmazonLinux used inside BastionHostLinux with latestAmazonLinux2 to remove the warning.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[corymhall]

@clueleaf thanks for creating this PR! It looks like changing the machine image results in a breaking change (the instance will be replaced) so this will have to be behind a feature flag.

If you are up for that then we should also make machineImage a required property and not default it for the user. Since we can't make it required from a type perspective we'll have to do it with a check inside the construct.

[clueleaf]

@corymhall
Thanks for your review.
I'm not sure if we should call this a breaking change, because the document is already clarifying that the instance may be replaced on every deployment when we do not specify a machineImage.

aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/bastion-host.ts

Lines 66 to 67 in 048d579

	* @default - An Amazon Linux 2 image which is kept up-to-date automatically (the instance
	* may be replaced on every deployment) and already has SSM Agent installed.

[corymhall]

I'm not sure if we should call this a breaking change, because the document is already clarifying that the instance may be replaced on every deployment when we do not specify a machineImage.

Good point!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[clueleaf]

@corymhall hi, will this PR get merged?

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: dfcbf37
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).