Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): Add missing ARNs for cloudwatch lambda insights #26153

Merged
merged 14 commits into from
Jun 30, 2023

Conversation

orekav
Copy link
Contributor

@orekav orekav commented Jun 28, 2023

Describe the feature

Add Lambda Layer Insights new version to CLOUDWATCH_LAMBDA_INSIGHTS_ARNS (packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts)
Also fixes missing ARNs for version 1.0.178.0 and others

Use Case

Take advantage of the bug fixes in

Proposed Solution

Add missing ARNs and adds latest Lambda Layer Version (1.0.229.0)

Closes #26150.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 28, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 28, 2023 17:34
@github-actions github-actions bot added the p2 label Jun 28, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Jun 28, 2023
@orekav orekav marked this pull request as ready for review June 28, 2023 17:46
@pahud pahud changed the title feat(lambda): cloudwatch lambda insights chore(lambda): Add missing ARNs for cloudwatch lambda insights Jun 28, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 28, 2023 17:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@orekav orekav changed the title chore(lambda): Add missing ARNs for cloudwatch lambda insights feat(lambda): add insights version 1.0.229.0 Jun 28, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@orekav orekav changed the title feat(lambda): add insights version 1.0.229.0 chore(lambda): Add missing ARNs for cloudwatch lambda insights Jun 28, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 28, 2023 18:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 29, 2023
corymhall
corymhall previously approved these changes Jun 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed corymhall’s stale review June 30, 2023 12:17

Pull request has been modified.

@orekav
Copy link
Contributor Author

orekav commented Jun 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

I am sorry. I haven't seen your message. I noticed that codeBuild failed and the branch was not up to date anymore. I have just pressed "Update branch".

@orekav
Copy link
Contributor Author

orekav commented Jun 30, 2023

@corymhall I pressed Update Branch :/

@orekav orekav requested a review from corymhall June 30, 2023 12:22
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 86f41f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

region-info: Missing Lambda Insights Layer 1.0.229.0
3 participants