-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(app-staging-synthesizer): tool to test maximum ecr repository allowance #26173
Conversation
One final thing that just occurred to me: whatever the number is at any one point, we can never lower it. Can you add a test that creates 14 different images and synths, to check that we can successfully add at least 14 images? Name the test and/or put a comment next to it so that it's very obvious why it's testing that, so that a person in the future doesn't go "well let me lower that number to 12 to make the test pass again". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's fix it at 20 and then ship it!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
And that maximum allowance right now is 20 (it's actually 21 but we are rounding down for safety).
Consistently, each additional repo adds 1369 bytes to the template. Before adding the inline functions, each additional repo was roughly 1200 bytes.
Current rough breakdown of size in the integ test (1 s3 bucket and 2 ecr repos):
25KB
~ 2KB for node version mapping
~ 6KB for auto delete images (4KB is the inline function)
~ 6KB for auto delete objects (4KB is the inline function)
Based on these calculations, it is semi reasonable that the repo allowance has gone from 38 to 21.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license