fix(ec2): flowLogName property for FlowLog construct does not work

[tam0ri]

Currently, flowLogName property for FlowLog L2 is never referred in generated CloudFormation template. This PR solves the issue by adding Name tag with the value of flowLogName property.

Closes #26370

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[tam0ri]

I'll do integ test and add snapshots later.

[watany-dev]

Are you saying that originally this resource did not have a property to attach a first place identifier, but L2Constructs had an interface?　The method of assigning a Name tag makes sense, but I thought that as a user of CDK constructs, I should be able to determine in advance whether it is a standard Nameid or tag support. Otherwise, users may use this property and Nametag at the same time.

[tam0ri]

@watany-dev Thank you for your comment. The physical ID (identifier) for AWS::EC2::FlowLog resource is flow log id. It's automatically generated by EC2 CreateFlowLogs API, and users can't define this id. Also, VPC flow log itself does not have a property like name in the API model. So, we can't specify the resource name in neither EC2 API and CloudFormation.

From the above technical background, currently flowLogName property for FlowLog construct is never used in generated CloudFormation template. This fix will utilize this property as the tag value for this resource. If Name tag is attached to flow log, VPC console shows the value as Name. Does it makes sense?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[watany-dev]

1. disable flowLogName specification following CFn
2. treat it as a Tag like this commit, and emphasize that it should be expressed as a Nametag so that users understand it.
   I personally think 2 is the way to go, but I'm waiting to see what the owners of CDK think.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[lpizzinidev]

Looks good to me 👍
Thanks for the contribution!

[rix0rrr]

Thanks!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f19e8c9
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).