Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): deployment alarm configurations are being added in isolated partitions #26458

Merged
merged 8 commits into from
Jul 21, 2023
Merged

fix(ecs): deployment alarm configurations are being added in isolated partitions #26458

merged 8 commits into from
Jul 21, 2023

Conversation

bvtujo
Copy link
Contributor

@bvtujo bvtujo commented Jul 20, 2023 •
edited by madeline-k
Loading

Fixes #26456.

Renames the isolated partitions to their correct names.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 20, 2023 20:51
@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK bug This issue is a bug. p2 labels Jul 20, 2023
@madeline-k madeline-k changed the title chore(ecs): fix isolated partitions in deployment alarms validation fix(ecs): deployment alarm configurations are being added in isolated partitions Jul 20, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

madeline-k
madeline-k previously requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update or add a unit test to verify this behavior?

@mrgrain mrgrain added p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed p2 labels Jul 21, 2023
mrgrain
mrgrain previously approved these changes Jul 21, 2023
View reviewed changes
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 21, 2023 10:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain dismissed madeline-k’s stale review July 21, 2023 10:43

Request has been addressed

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review July 21, 2023 12:03

Pull request has been modified.

mrgrain
mrgrain previously approved these changes Jul 21, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

madeline-k
madeline-k previously approved these changes Jul 21, 2023
View reviewed changes
@madeline-k
Copy link
Contributor

Just the cloud-assembly-schema tests are failing. That should be unrelated to this change, so we may need to wait for that to be fixed on main.

@mergify mergify bot dismissed stale reviews from madeline-k and mrgrain July 21, 2023 17:43

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 21, 2023
mrgrain
mrgrain previously requested changes Jul 21, 2023
View reviewed changes
packages/cdk-cli-wrapper/.warnings.jsii.js Outdated Show resolved Hide resolved
@mergify mergify bot dismissed mrgrain’s stale review July 21, 2023 18:16

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a25fdc8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit eea223b into aws:main Jul 21, 2023
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@bvtujo @bmoffatt
fix(ecs): deployment alarm configurations are being added in isolated…
dad54a4 
… partitions (aws#26458)

Fixes aws#26456. 

Renames the isolated partitions to their correct names. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
@peterwoodworth peterwoodworth mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@madeline-k madeline-k madeline-k left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-ecs: Incorrect Partition Names For Disabling ECS Alarms
4 participants
@bvtujo @madeline-k @aws-cdk-automation @mrgrain