Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sam): CfnFunction events are not rendered #26679

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Commits on Aug 9, 2023

  1. fix(sam): CfnFunction events are not rendered

    Because of a mistake introduced into the SAM schema, the `AlexaSkill`
    event type doesn't have any required properties anymore.
    
    When the `CfnFunction` is trying all the different event types in the
    type union that it supports, it will go through every type in
    alphabetical order and pick the first type that doesn't fail its
    validation.
    
    After the schema change, the first type (`Alexa` which starts with an
    `A`) would therefore accept all types: no required fields, and for
    JavaScript compatibility purposes we allow superfluous fields, and so
    we pick a type that doesn't render anything.
    
    This change reorders the alternatives in the union such that stronger
    types are tried first.
    
    `HttpApiEvent` and `AlexaSkillEvent` both have no required
    properties, and this now reverses the problem: `AlexaSkillEvent` can
    no longer be specified because `HttpApiEvent` will match first.
    
    But that's the more common use case, so better for now, while we wait
    for the spec fix to come in, to prefer the HTTP API.
    
    Relates to #26637.
    rix0rrr committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    86bd4be View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. drop coverage

    rix0rrr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    580adf1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13ecaf2 View commit details
    Browse the repository at this point in the history