fix(servicecatalog): only one ProductStack per Portfolio can use assets #26885
Conversation
github-actions
bot
added
p2
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
changed the title
rix0rrr
changed the title
aws-cdk-automation
added
the
pr/needs-maintainer-review
| @@ -869,3 +872,10 @@ export interface UserDefinedObjectMetadata { | |||
| */ | |||
| readonly [key: string]: string; | |||
| } | |||
|
|
|||
| function sourceConfigEqual(stack: cdk.Stack, a: SourceConfig, b: SourceConfig) { | |||
There was a problem hiding this comment.
safer to check the equality of stringified SourceConfig minus bucket? If we add a new propr to SourceConfig in the future then this function will silently be inaccurate. Although SourceConfig hasn't changed in 4 years... not a big deal
JSON.stringify({...a, bucket: undefined}) === JSON.stringify({...b, bucket: undefined})There was a problem hiding this comment.
Ok, this isn't really supposed to be a blocker. I will leave it up as an open question and if you agree you can open a new PR later.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
To move the assets into the target bucket, a
BucketDeploymentwas created for everyProductStack. Instead, we will now share the sameBucketDeploymentfor allProductStacks.This moves the custom resource around in the construct tree (leading to replacement), but that is a safe operation. Nothing will be destroyed by this move.
Closes #25189.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license