docs(redshift): add details on cluster resizing #26928
Conversation
github-actions
bot
added
effort/medium
msambol
changed the title
|
|
||
| As your data warehousing needs change, it's possible to resize your Redshift cluster, but it's important to understand certain caveats. | ||
| Most importantly, if the cluster was deployed via CDK, the cluster should be resized via CDK so it's registered in the AWS CloudFormation template. | ||
| This ensures the `NumberOfNodes` parameter gets updated so the correct type of resize is done. There are two types of resize operations: |
There was a problem hiding this comment.
CFN has this as NumberOfNodes, CDK has it as numberOfNodes. I felt it best to be NumberOfNodes to represent the CFN template.
There was a problem hiding this comment.
I think this whole sentence can be removed. Just noting that the resize has to be done via CloudFormation is a good reminder, no need to go into detail. You are saying "certain caveats". Are there more than one?
As for your casing example: as a rule, I would say that CDK documentation should stay in CDK-land, and not presume CloudFormation knowledge. I know this is not entirely achievable always, but that should be our goal. The point is moot though, again, I would remove the sentence.
aws-cdk-automation
added
the
pr/needs-community-review
|
|
||
| As your data warehousing needs change, it's possible to resize your Redshift cluster, but it's important to understand certain caveats. | ||
| Most importantly, if the cluster was deployed via CDK, the cluster should be resized via CDK so it's registered in the AWS CloudFormation template. | ||
| This ensures the `NumberOfNodes` parameter gets updated so the correct type of resize is done. There are two types of resize operations: |
There was a problem hiding this comment.
I think this whole sentence can be removed. Just noting that the resize has to be done via CloudFormation is a good reminder, no need to go into detail. You are saying "certain caveats". Are there more than one?
As for your casing example: as a rule, I would say that CDK documentation should stay in CDK-land, and not presume CloudFormation knowledge. I know this is not entirely achievable always, but that should be our goal. The point is moot though, again, I would remove the sentence.
| * Elastic resize - You can add nodes to or remove nodes from the cluster. Also, you can change the node type, such as from DS2 nodes to RA3 nodes. | ||
| AWS recommmends elastic resize as the first option, as it's a fast operation and typically completes in minutes. Elastic resize is appropriate when you: | ||
| * Add or reduce nodes in your existing cluster, but don't change the node type. | ||
| * Change the node type of your cluster. |
There was a problem hiding this comment.
It sounds like elastic resize applies when you change the node count, or the node type, but not both at the same time. Is that a fair summarization?
| * Classic resize - Number of nodes, node type, or both, can be changed. This operation takes longer to complete, but is useful when the resize operation | ||
| doesn't meet the criteria of an elastic resize. See [AWS Knowledge Center](https://repost.aws/knowledge-center/redshift-troubleshoot-elastic-resize) for further conditions that require classic resizing. |
There was a problem hiding this comment.
It feels a bit like teasing to say "see this other place for the conditions". Can you summarize? Or is it by exclusion, everything that's not an elastic resize is a classic resize?
Also, do people have to do anything to their code to pick one or the other resize? Please explain if they do or do not.
There was a problem hiding this comment.
Added more details on conditions and clarified that elastic is default but there is an option to set classic 👍🏼
aws-cdk-automation
removed
the
pr/needs-community-review
msambol
force-pushed
the
redshift-resizing
branch
from
8546f8f
to
20bbe85
Compare
msambol
force-pushed
the
redshift-resizing
branch
6 times, most recently
from
a2dae5a
to
3cd45a6
Compare
msambol
force-pushed
the
redshift-resizing
branch
from
3cd45a6
to
3fcdfea
Compare
|
@rix0rrr Thanks for the feedback! Updated per your comments. |
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I felt it best to keep most of the details in the linked documentation, but I believe this provides a good overview. Closes #21103. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I felt it best to keep most of the details in the linked documentation, but I believe this provides a good overview.
Closes #21103.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license