feat(eks): allow associating external oidc provider with cluster

[Advill]

Implement associateOpenIdConnectProvider method in Cluster resource.

Implement test for connecting an OIDC resource after creating a cluster

A project I'm working on has fairly strict requirements from the managing IT org around IAM resources. Long story short, they'd prefer that we spin up our clusters and let them add OIDC providers to them. Currently there is no way to short-circuit the lazy OIDC creation logic or to provide a cluster with an OIDC provider manually.

This PR simply grabs an OIDC provider by it's ARN and slots it in the internal OIDC variable.

The added test could probably use some work. I'm not familiar enough with jest or the CDK's Template construct to work out how to check that a certain resource type is not provisioned in a synthesis, but I've tested what I can.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mrgrain]

Hi, can you describe the use case in more detail? Specifically how are you making sure that this "external" OIDC provider hast the correct url?

[mrgrain]

This would need to accept a IOpenIdConnectProvider. not an ARN.

[Advill]

For sure, I was pretty new to the CDK and my exact use case when I first made this PR. Still finishing up some more important work but once I finish I'm going to clean this up and finish off the parts the PR is missing.

[Advill]

Hi, can you describe the use case in more detail? Specifically how are you making sure that this "external" OIDC provider hast the correct url?

The use case is certainly an edge one, but is pretty accurately described in the above post. I could add some checks to the imported OIDC provider to try to ensure that it's configured correctly but I'll need to get more familiar with the creation process for OIDCs for that and it may take some back and forth on the request.

In impementing this, hopefully at least a few other users with specific use cases like mine would be able to jump past the OIDC creation requirement of automatically adding ALBControllers and ServiceAccounts using provided functions, if it seems like I'm alone in this requirement though it's fair if this PR is denied.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 0b2eeca
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mrgrain]

Hi, can you describe the use case in more detail? Specifically how are you making sure that this "external" OIDC provider hast the correct url?

The use case is certainly an edge one, but is pretty accurately described in the above post. I could add some checks to the imported OIDC provider to try to ensure that it's configured correctly but I'll need to get more familiar with the creation process for OIDCs for that and it may take some back and forth on the request.

In impementing this, hopefully at least a few other users with specific use cases like mine would be able to jump past the OIDC creation requirement of automatically adding ALBControllers and ServiceAccounts using provided functions, if it seems like I'm alone in this requirement though it's fair if this PR is denied.

Thanks your response. I'm happy to move forward with this, but we will need to use the interface for it.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.