Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add Amazon Linux 2023 to EcsOptimizedImage #26989

Merged
merged 5 commits into from
Sep 9, 2023
Merged

feat(ecs): add Amazon Linux 2023 to EcsOptimizedImage #26989

merged 5 commits into from
Sep 9, 2023

Conversation

layertwo
Copy link
Contributor

@layertwo layertwo commented Sep 3, 2023

Add support for selecting Amazon Linux 2023 ECS Optimized images.

Reference: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html

Closes #26988.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Sep 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 3, 2023 00:56
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 3, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@layertwo layertwo changed the title feat(aws-ecs): add Amazon Linux 2023 to EcsOptimizedImage feat(ecs): add Amazon Linux 2023 to EcsOptimizedImage Sep 3, 2023
@layertwo
Copy link
Contributor Author

layertwo commented Sep 3, 2023

Exemption Request:

This is an expansion of the existing capability for EcsOptimizedImage, and not a whole new feature that would require changes to an integration test or README.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 3, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 3, 2023
@layertwo
Copy link
Contributor Author

layertwo commented Sep 8, 2023

@pahud would you be willing to review this? re: #26988

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exempt-test The PR linter will not require test changes labels Sep 9, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 9, 2023 09:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9a4ccb8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0bac8a5 into aws:main Sep 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@layertwo layertwo deleted the ecs-optimized-amazon-2023 branch September 9, 2023 20:47
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
Add support for selecting Amazon Linux 2023 ECS Optimized images.

Reference: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html

Closes #26988.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-ecs): add support for Amazon Linux 2023 in EcsOptimizedImage
3 participants