Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(globalaccelerator): add integ test for Global Accelerator with Endpoints #27093

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 11, 2023

This also tests the usage of AwsCustomResource to describe security groups. Manually tested the unhappy path: If not SG can be found, the stack deployment fails as expected.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… Endpoints

This also tests the usage of AwsCustomResource to describe security groups.
Manually tested the unhappy path: If not SG can be found, the stack deployment fails as expected.
@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2023 10:30
@github-actions github-actions bot added the p2 label Sep 11, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8c2a938
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 23fba8a into main Sep 11, 2023
8 checks passed
@mergify mergify bot deleted the mrgrain/chore/global-accelerator-test branch September 11, 2023 12:04
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
…Endpoints (#27093)

This also tests the usage of AwsCustomResource to describe security groups. Manually tested the unhappy path: If not SG can be found, the stack deployment fails as expected.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants