-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Schedule
class
#27105
Merged
Merged
feat(core): Schedule
class
#27105
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
2a37ef5
prelim scheduel in core
kaizencc 1a7848e
fix schedule
kaizencc c1d2e2e
expose backup.Schedule, create BackupPlanRule.schedule, deprecated Ba…
kaizencc 9597cd8
add timezone to at expression
kaizencc e72f216
add bind to core.Schedule, rename protected methods as protectedXxx c…
kaizencc 89e2355
move schedule.ts to helpers-internal
kaizencc 8645d07
move schedule back tto main
kaizencc 72ec383
export
kaizencc f59f475
synthetics
kaizencc 2c04d30
scheduler
kaizencc 404ab4c
touchups
kaizencc eda29d3
Merge branch 'main' into conroy/schedulecore
kaizencc 97e492e
add annotations and fix some tests
kaizencc 863d720
Merge branch 'main' into conroy/schedulecore
kaizencc 8399112
Update packages/aws-cdk-lib/aws-backup/lib/schedule.ts
kaizencc 20cb339
rename to CoreSchedule
kaizencc 223070e
backup synth check
kaizencc b1940c7
autoscaling timezone test
kaizencc 380bf5f
finally fixed nuance in autoscaling.Schedule
kaizencc ab7a05a
Merge branch 'main' into conroy/schedulecore
kaizencc acd58a2
add documentation
kaizencc c64a3ca
fix bugs and tests in scheduler
kaizencc 66d1df7
finalize schedule class
kaizencc 70ac3bf
minor test fixes
kaizencc 40f4078
test schedule in core
kaizencc 240a016
Merge branch 'main' into conroy/schedulecore
kaizencc 1e444c8
fix tests
kaizencc 44b535e
lint
kaizencc b1f3603
Merge branch 'main' into conroy/schedulecore
kaizencc a530f35
snappies
kaizencc 094c454
Merge branch 'main' into conroy/schedulecore
kaizencc 3697f55
fix cronoptions
kaizencc 77fd854
Update packages/@aws-cdk/aws-scheduler-alpha/test/schedule-expression…
kaizencc 1efab47
Merge branch 'main' into conroy/schedulecore
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 3 additions & 3 deletions
6
...ting/framework-integ/test/aws-backup/test/integ.backup.js.snapshot/cdk-backup.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...es/@aws-cdk-testing/framework-integ/test/aws-backup/test/integ.backup.js.snapshot/cdk.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"version":"32.0.0"} | ||
{"version":"34.0.0"} |
2 changes: 1 addition & 1 deletion
2
...@aws-cdk-testing/framework-integ/test/aws-backup/test/integ.backup.js.snapshot/integ.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"version": "33.0.0", | ||
"version": "34.0.0", | ||
"testCases": { | ||
"integ.backup": { | ||
"stacks": [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...teg/test/aws-dynamodb/test/integ.autoscaling.lit.js.snapshot/aws-cdk-dynamodb.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...-testing/framework-integ/test/aws-dynamodb/test/integ.autoscaling.lit.js.snapshot/cdk.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"version":"20.0.0"} | ||
{"version":"34.0.0"} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the timezone by default should be etc_utc, so I don't see a problem with adding this diff to the template