-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3-deployment): support Fn::Select in renderData() #27237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
c1cc98a
to
4cc8dcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly this whole function seems a little silly. Feels like we could accept EVERY intrinsic.
But thanks for the contribution, we're at least better off than we were before!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio refresh |
✅ Pull request refreshed |
@rix0rrr The Mergify job
I see from the comment on this PR by the Mergify bot that:
However the GitHub Action is suggesting that I try updating locally. How do I resolve this to get it embarked? Note that "Allow edits from maintainers" is enabled. |
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
@Mergifyio rebase |
❌ Unable to rebase: user
|
Pull request has been modified.
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refresh Approval
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #25504
The reason for this change is to support more complex Cloudformation references used within
Source.data
inaws-s3-deployment
. The objects today only supportRef
orFn::GetAtt
Cfn references, which is limiting when it comes to attempting to manipulate Cfn references at deploy-time, such as viaFn::Split
orFn::Select
. Many AWS CDK functions return tokens that must be evaluated using these complex Cfn functions (see ApplicationTargetGroup's firstLoadBalancerFullName attribute), but they are incompatible withrenderData
!This is a blocking issue for CDK projects which rely on generating S3 objects using
BucketDeployment
, wherein the rendered data is generated from native functions which utilize Cfn functions under-the-hood to dynamically construct values at deploy-time.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license