Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): remove invalid data protection data identifier #27388

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix(logs): remove invalid data protection data identifier #27388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46eebae
fix(logs): Remove invalid PHONENUMBER data identifier in data protect…
Oct 2, 2023
187144c
Merge branch 'main' into LogGroup-DataProtectionPolicy
mergify[bot] Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions allowed-breaking-changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,3 +226,6 @@ base-types:aws-cdk-lib.aws_autoscaling.CronOptions
removed:aws-cdk-lib.aws_autoscaling.CronOptions.timeZone
removed:aws-cdk-lib.aws_autoscaling.CronOptions.year
removed:aws-cdk-lib.aws_backup.BackupPlanRuleProps.schedule

# This data identifer was added by mistake; it had never worked.
removed:aws-cdk-lib.aws_logs.DataIdentifier.PHONENUMBER
1 change: 0 additions & 1 deletion packages/aws-cdk-lib/aws-logs/lib/data-protection-policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ export class DataIdentifier {
public static readonly PERMANENTRESIDENCENUMBER_CA = new DataIdentifier('PermanentResidenceNumber-CA');
public static readonly PERSONALHEALTHNUMBER_CA = new DataIdentifier('PersonalHealthNumber-CA');
public static readonly PGPPRIVATEKEY = new DataIdentifier('PgpPrivateKey');
public static readonly PHONENUMBER = new DataIdentifier('PhoneNumber');
public static readonly PHONENUMBER_BR = new DataIdentifier('PhoneNumber-BR');
public static readonly PHONENUMBER_DE = new DataIdentifier('PhoneNumber-DE');
public static readonly PHONENUMBER_ES = new DataIdentifier('PhoneNumber-ES');
Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk-lib/awslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,6 @@
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PERMANENTRESIDENCENUMBER_CA",
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PERSONALHEALTHNUMBER_CA",
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PGPPRIVATEKEY",
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PHONENUMBER",
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PHONENUMBER_BR",
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PHONENUMBER_DE",
"docs-public-apis:aws-cdk-lib.aws_logs.DataIdentifier.PHONENUMBER_ES",
Expand Down
Loading