Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): declare cdk import stable #27390

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 3, 2023

The cdk import feature has existed for a year and a half. Since then, we've only had one major bug report around multiple identifiers (#20895) which was fixed half a year ago.

This feature seems solid enough to remove the "Preview" label. There is only one remaining limitation around Nested Stacks, but this feature could be addressed without breaking backwards compatibility.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The `cdk import` feature has existed for a year and a half. Since then,
we've only had one major bug report around multiple identifiers (#20895)
which was fixed half a year ago.

This feature seems solid enough to remove the "Preview" label. There is
only one remaining limitation around Nested Stacks, but this feature
could be addressed without breaking backwards compatibility.
@rix0rrr rix0rrr requested a review from a team October 3, 2023 12:09
@github-actions github-actions bot added the p2 label Oct 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 3, 2023 12:09
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 3, 2023
@rix0rrr rix0rrr changed the title feat(cli): consider cdk import stable feat(cli): declare cdk import stable Oct 3, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 3, 2023
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Oct 4, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 4, 2023 09:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cd35ad1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1057ef0 into main Oct 4, 2023
12 of 13 checks passed
@mergify mergify bot deleted the huijbers/stabilize-cdk-import branch October 4, 2023 10:15
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants