feat(ec2): Add SubnetFilter for CIDR Range #27425
Conversation
github-actions
bot
added
effort/small
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
AlemanCS
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
added
pr/needs-maintainer-review
| @@ -43,6 +43,13 @@ export abstract class SubnetFilter { | |||
| return new CidrMaskSubnetFilter(mask); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
NIT: Hey, could you add @params for the function argument here?
There was a problem hiding this comment.
Just added this @param cidrs List of CIDR ranges to filter subnets from
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds a new SubnetFilter ,
CidrRangesSubnetFilter, which filter subnets if they are included in a given list of CIDR ranges. This becomes helpful if a VPC has multiple CIDR ranges and you want to select subnets for only a specific CIDR range or multiple.Note: It is a bit difficult to write unit tests as CDK doesn't have the ability to add a secondary CIDR to a VPC.
Closes #27421
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license